[x3d-public] new set of patches for www.web3d.org/X3D/Stylesheets.

John Carlson yottzumm at gmail.com
Sun Dec 10 08:53:31 PST 2017


Note if Nashorn includes it’s own xmldom implementation, then xmldom is not required and may be taken out.  Xmldom is under nashorn/node_modules as a separate included package.  It is installed with npm install.

X3DJSONLD is intimate with xmldom, so we may have to change the version of X3DJSONLD.js under nashorn/node or the way document is created.  That shouldn’t be an issue.  It’s been a while since I dealt with Java’s DOM.

John

Sent from Mail for Windows 10

From: John Carlson
Sent: Sunday, December 10, 2017 11:29 AM
To: Don Brutzman; x3d-public at web3d.org
Subject: new set of patches for www.web3d.org/X3D/Stylesheets.

Patches below have been updated.  This one is nearly working except for  final output .js file (uses \, so there’s no folder separator…writes to nashornexamplesHello…), and \\” in the JSON in JavaScript output from X3DJSAIL.

Intermediate JS with bugs is linked.  Please correct X3DJSAIL to output correct version. I can send a patched version if you want a version which “does the right thing”

Generally,  I run test.bat, then,

jjs nashorn/examples/HelloWorldProgramOutput.js.intermediate.js

since test.bat does not complete.


Zip file should be unpacked in www.web3d.org/x3d/stylesheets, and patch should run from same folder.

Call me if you need help patching. There may be excess patches in the patch, but already knocked out several.  Main files are Create….xslt, build.xml and X3dToJava.xslt, I think.  X3dToJava.xslt as it stands created 2 nested CDATA sections, so I got rid of one of them.

John

Sent from Mail for Windows 10

From: John Carlson
Sent: Monday, November 20, 2017 1:55 PM
To: x3d-public at web3d.org; Don Brutzman
Subject: FW: patches to x3d-code/www.web3d.org/x3d/stylesheets

Don,

New patches available in place of old ones, likely very shortened.  Fixed ConfigurationProperties.XSLT_ENGINE_NATIVE_JAVA symbol bug, but probably need to reset value back to original setting.


https://coderextreme.net/X3DJSONLD/x3d.stylesheets.zip (additional code for test-nashorn build target, includes OSS licensed files)

https://coderextreme.net/X3DJSONLD/x3d.stylesheets.patch.gz (patch for stylesheets folder)

https://coderextreme.net/X3DJSONLD/HelloWorldProgramOutput.js.intermediate.js.gz (buggy JavaScript output from ant test-nashorn)

Please examine JavaScript output for \ quoting bugs in X3dToJson.xslt (try running it similar to the JavaScript found in test-nashorn build target).

We may have to switch XSLT engines for JSON output.

Please at least apply the patch to CreateX3dSceneAccessInterfaceJava.xslt as that’s the most difficult one to maintain, and we will have to most conflicts.  I’ve already patched it 2 – 3 times now for JavaScript output.

I’ve upgraded my ant to 1.10.1

Build target test-nashorn still doesn’t complete, due to bad conversion to JSON.  May be tested with test.bat from zip.

Thanks,

John


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://web3d.org/pipermail/x3d-public_web3d.org/attachments/20171210/85f08610/attachment.html>


More information about the x3d-public mailing list