[x3d-public] X3DJSAIL updates: Patches to X3DJSAIL and build.xml, plus test.bat and nashorn additions

[Don Brutzman]

On 12/16/2017 11:40 PM, John Carlson wrote:
> Patch to X3DJSAIL and build.xml
> attached: x3d.stylesheets.patch

OK, was able to get Netbeans to partially apply the patch (for build.xml only).

Have modified stylesheets/build.xml as indicated.  renamed ant target test-nashorn to test.nashorn for consistency with other targets.  checked in.

The patch for CreateX3dSceneAccessInterfaceJava.xslt didn't get applied by Netbeans... so I did it manually.  Checked in.

*Please confirm* manual patch to CreateX3dSceneAccessInterfaceJava.xslt was applied OK.

On 12/16/2017 11:50 PM, John Carlson wrote:
> Corresponding zip file with nashorn source code:
> 
> https://coderextreme.net/X3DJSONLD/x3d.stylesheets.zip

OK the content there (test.bat and nashorn) has been extracted into stylesheets directory.  Looks like you wanted it in stylesheets/nashorn, which is a peer of stylesheets/java (where X3DJSAIL gets autogenerated).

Everything from before (including smoke tests) still builds and runs OK.

Everything is checked in.

However, *also please advise* about location: am thinking that the nashorn directory tree needs to get moved from stylesheets/ level down inside stylesheets/java/ so that it can be included in x3djail.full.jar

Further, the test.nashorn target isn't working happily, ant is having with your nashorn script.  Console follows.

=================================================================
ant -f C:\\x3d-code\\www.web3d.org\\x3d\\stylesheets test.nashorn
test.nashorn:
Compiling 1 source file to C:\x3d-code\www.web3d.org\x3d\stylesheets\java\classes
Warning: toFileJavaScript() is overwriting prior file nashorn/examples/HelloWorldProgramOutput.js
Script DEF=colorTypeConversionScript contains CDATA source-code text, copied as "#sourceText" using "strings" mode
Script DEF=MaterialModulatorScript contains CDATA source-code text, copied as "#sourceText" using "strings" mode
HelloWorldProgramOutput self-validation test results: success
C:\x3d-code\www.web3d.org\x3d\stylesheets\build.xml:1594:
org.apache.bsf.BSFException: unsupported language: nashorn
	at org.apache.bsf.BSFManager.loadScriptingEngine(BSFManager.java:686)
	at org.apache.bsf.BSFManager.exec(BSFManager.java:485)
	at org.apache.tools.ant.util.optional.ScriptRunner.executeScript(ScriptRunner.java:98)
	at org.apache.tools.ant.taskdefs.optional.Script.execute(Script.java:53)
	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293)
	at sun.reflect.GeneratedMethodAccessor175.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at org.apache.tools.ant.Target.execute(Target.java:435)
	at org.apache.tools.ant.Target.performTasks(Target.java:456)
	at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405)
	at org.apache.tools.ant.Project.executeTarget(Project.java:1376)
	at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
	at org.apache.tools.ant.Project.executeTargets(Project.java:1260)
	at org.apache.tools.ant.module.bridge.impl.BridgeImpl.run(BridgeImpl.java:286)
	at org.apache.tools.ant.module.run.TargetExecutor.run(TargetExecutor.java:555)
	at org.netbeans.core.execution.RunClassThread.run(RunClassThread.java:153)
BUILD FAILED (total time: 3 seconds)
=================================================================

all the best, Don
-- 
Don Brutzman  Naval Postgraduate School, Code USW/Br       brutzman at nps.edu
Watkins 270,  MOVES Institute, Monterey CA 93943-5000 USA   +1.831.656.2149
X3D graphics, virtual worlds, navy robotics http://faculty.nps.edu/brutzman