[x3d-public] Changes to X3DJSAIL accepted? Final! outstanding error in my datafolder for X3DJSAIL[ with my patches, of course ] - getting to v1.0

[John Carlson]

Don, the problem is that MY X3DJSAIL Java programs generated with my serializer does not produce proper JSON files.  I don’t think the XML files are good either, but I would have to revisit my nashorn stuff or change my serializer to output XML.  I can do that if you want, but I would prefer fixing X3DJSAIL.  Please edit my Java code and place the JSON file where you like (not overriding the originals, and run and compare output).  You can search for \ I think.

You don’t see the problem until you look.

John
Sent from Mail for Windows 10

From: Don Brutzman
Sent: Tuesday, May 23, 2017 11:54 PM
To: John Carlson
Cc: X3D Graphics public mailing list
Subject: Re: Changes to X3DJSAIL accepted? Final! outstanding error in my datafolder for X3DJSAIL[ with my patches, of course ] - getting to v1.0

p.s. just to be clear, the X3DJSAIL library is different than the X3dToJson.xslt and X3dToJava.xslt stylesheets.  That is where we can keep working on mappings between encodings.  The library seems to be pretty stable regardless.

On 5/23/2017 8:05 AM, Don Brutzman wrote:
> Hi John.  The patches are useful but take some sleuthing on this end, unfortunately. I can't really apply them directly because the actual code that gets changed is in the X3DJSAIL generation stylesheet, which always replaces all of the end-product .java source.
> 
> If you might include comments in your patches, perhaps pointing to example scene or describing what it is fixing, that will help me get the proper correction applied.
> 
> All of the immense unit testing we continue to pursue is really productive.  Last night's end-to-end Java retest exposed three scenes with fixable errors (corrections already checked in) and identified another SAI idiosyncracy.  Better and better!
> 
> Since we are getting very close to full coverage, and since the API seems quite stable for a while now.  I'm just about ready to declare that X3DJSAIL is ready for v1.0 and sufficiently stable for production use.
> 
> Please advise if you think there are any critical bugfixes for that milestone.  Testing and improvements and feature additions will continue, of course.  TIA.
> 
> On 5/20/2017 7:38 PM, John Carlson wrote:
>> Do I need to make changes to the stylesheet for X3DJSAIL to accept my patches?  Please let me know!  Also insure that JSON output is correct from X3DJSAIL after stylesheet changes.  You will need to will need to add my patches to make reasonable Java and JavaScript code output correct XML and JSON, methinks.  Patch to X3DJSAIL Java code is attached, Also to find field type and access types from fieldValue names in ProtoInstances and fieldValues (in the field or (Extern)ProtoDeclare field).
[...]

As before, patches are helpful but can't be applied "as is" to the code generator and so knowing the example cases each is addressing is helpful to ensure that the correct modifications are applied to the library.  Again thanks.

all the best, Don
-- 
Don Brutzman  Naval Postgraduate School, Code USW/Br       brutzman at nps.edu
Watkins 270,  MOVES Institute, Monterey CA 93943-5000 USA   +1.831.656.2149
X3D graphics, virtual worlds, navy robotics http://faculty.nps.edu/brutzman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://web3d.org/pipermail/x3d-public_web3d.org/attachments/20170524/34786fa8/attachment-0001.html>