[x3d-public] FW: X3DJSAIL build. Junit jar missing.

[John Carlson]

Don, Great!  Now there are a several more Nashorn related issues to resolve.

I will try to get to them in the short term, but you can look at the nashorn build.xml and figure out what needs to be updated to build nashorn/examples.  I don’t think it’s all up to date, and not all the tests are active, I don’t think, thus when diffs are made, there are excess errors I think.  The test.nashorn build.xml needs to be cleaned up and checked for real issues.

These two diffs should be up to date.   Variation in comments and the missing fieldValues and ProtoInstances seem the most pressing.  There is no way to add containerField in JavaScript, so we’ll have to figure out something (LIKE IF I CALL setMaterial, set the containerField!).

Here are some errors being thrown from test.nashorn that seem related to the second diff:

  [exec] [X3DLoaderObject error] ProtoInstance ArtDeco01Material found and node type is Material but containerField is missing, unable to add to scene graph
     [exec] [X3DLoaderObject error] ProtoInstance ArtDeco02Material found and node type is ExternProtoDeclare but containerField is missing, unable to add to scene graph
     [exec] [X3DLoaderObject error] ProtoInstance  found and node type is ExternProtoDeclare but containerField is missing, unable to add to scene graph
     [exec] [X3DLoaderObject error] ProtoInstance MaterialModulator found and node type is Material but containerField is missing, unable to add to scene graph

This may be the lack of X3DJSONLD adding a containerField.  I will have to check versions and language differences.  I made one change to X3DJSONLD.js, but I don’t see any differences.  Also, I addFieldValue at the end of the scenegraph in Nashorn.js.  I am not sure if that makes a difference or not. Let me know.

Note that Nashorn0.x3d contains fieldValue, but Nashorn.x3d does not.   See nashorn/test.bat for producing Nashorn0.x3d

As far as I know, the process for building Nashorn.x3d and Nashorn0.x3d are similar, but the results are different (Nashorn0.x3d is the result of X3DJSONLD and Nashorn.x3d is the result of X3DJSAIL).  Weird. Please check my work.  If you find a difference in how they are built, let me know. Thanks!  Nashorn0.x3d seems more correct right now.  Please fix X3DJSAIL if possible.

Please look into missing ProtoInstances and fieldValues. Thanks!

John

$ diff HelloWorldProgramOutput.x3d HelloWorldProgramOutput.Nashorn.js.new.x3d
88c88
<                     <!-- alternative Java source: .setString(new String [] {"One, Two, Comment", "", "He said, \"Immel did it!\""}) -->
---
>                     <!-- alternative Java source: .setString(new String [] {"One, Two, Comment", "", "He said, \""Immel did it!\"""}) -->
107a108,109
>
>
114a117,119
>
>
>
151c156
<                 <ProtoInstance name='ArtDeco01Material' containerField='material'>
---
>                 <ProtoInstance name='ArtDeco01Material'>
161c166
<                 <ProtoInstance DEF='ArtDeco02MaterialDEF' name='ArtDeco02Material' containerField='material'>
---
>                 <ProtoInstance DEF='ArtDeco02MaterialDEF' name='ArtDeco02Material'>
171c176
<                 <ProtoInstance USE='ArtDeco02MaterialDEF' containerField='material'/>
---
>                 <ProtoInstance USE='ArtDeco02MaterialDEF'/>
209a215,216
>
>
225c232
<
---
>
232a240,242
>
>
>
243c253
<                     <ProtoInstance DEF='MyMaterialModulator' name='MaterialModulator' containerField='material'/>
---
>                     <ProtoInstance DEF='MyMaterialModulator' name='MaterialModulator'/>


diff -w HelloWorldProgramOutput.x3d Nashorn.x3d
32a33,35
>         <meta name='translated' content='29 June 2018'/>
>         <meta name='generator' content='X3dToJson.xslt, http://www.web3d.org/x3d/stylesheets/X3dToJson.html'/>
>         <meta name='reference' content='X3D JSON encoding: http://www.web3d.org/wiki/index.php/X3D_JSON_Encoding'/>
88c91
<                     <!-- alternative Java source: .setString(new String [] {"One, Two, Comment", "", "He said, \"Immel did it!\""}) -->
---
>                     <!-- alternative Java source: .setString(new String [] {"One, Two, Comment", "", "He said, \""Immel did it!\"\"}) -->
151,154d153
<                 <ProtoInstance name='ArtDeco01Material' containerField='material'>
<                     <!-- [HelloWorldProgram diagnostic] ArtDeco01ProtoInstance.getNodeType()="Material" -->
<                     <fieldValue name='description' value='ArtDeco01Material can substitute for a Material node'/>
<                 </ProtoInstance>
161,164d159
<                 <ProtoInstance DEF='ArtDeco02MaterialDEF' name='ArtDeco02Material' containerField='material'>
<                     <!-- [HelloWorldProgram diagnostic] ArtDeco02ProtoInstance.getNodeType()="ERROR_UNKNOWN_EXTERNPROTODECLARE_NODE_TYPE: ExternProtoDeclare name='ArtDeco02Material' type cannot be remotely accessed at run time, TODO X3DJSAIL needs to add further capability." -->
<                     <fieldValue name='description' value='ArtDeco02Material can substitute for another Material node'/>
<                 </ProtoInstance>
171d165
<                 <ProtoInstance USE='ArtDeco02MaterialDEF' containerField='material'/>
243d236
<                     <ProtoInstance DEF='MyMaterialModulator' name='MaterialModulator' containerField='material'/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://web3d.org/pipermail/x3d-public_web3d.org/attachments/20180629/b64987e1/attachment-0001.html>