[x3d-public] interesting test failure detected using X3DJSAIL

[Brutzman, Donald (Don) (CIV)]

On 11/11/2018 3:20 PM, John Carlson wrote:
> That didn’t come out right.  If I fix one of my data files, do you want me to send it to you?

Certainly any source and models in version control should be kept up to date.

Tests should either pass, or intentionally fail in order to confirm that diagnostics are working.  In either case, X3D model metadata "tells the story" so that results match expectations.

> On Sun, Nov 11, 2018 at 5:18 PM John Carlson <yottzumm at gmail.com <mailto:yottzumm at gmail.com>> wrote:
> 
>     Don, do you want me to send you errors in my data files if I have previously sent them to you?
> 
>     John
> 
>     On Sun, Nov 11, 2018 at 4:15 PM Brutzman, Donald (Don) (CIV) <brutzman at nps.edu <mailto:brutzman at nps.edu>> wrote:
> 
>         hi John.  i continue working on X3DJSAIL steadily and was reviewing some tests.
> 
>         adding a meta title to the attached scene allowed X3dToJava.xslt to figure out the correct class name, even when that wasn't passed as a parameter to the stylesheet.  (AFAIK, XSLT stylesheets do not have a way to figure out the filename of their inputs, since they could be streams.
> 
>         interestingly then the build script compiled and executed the corresponding .java and found a tupleness error that had eluded other QA tests:
> 
>         ====================
>         C:\x3d-code\www.web3d.org <http://www.web3d.org>\x3d\stylesheets\test>java arc
>         Exception in thread "main" org.web3d.x3d.sai.InvalidFieldValueException: Illegal MFVec3f newValue array length=7, must be multiple of 3 or else be empty (newValue=0 0 0 0 0 5 0)
>                   at org.web3d.x3d.jsail.fields.MFVec3fObject.<init>(MFVec3fObject.java:289)
>                   at arc.initialize(arc.java:86)
>                   at arc.<init>(arc.java:47)
>                   at arc.main(arc.java:206)
>         ====================
> 
>         commit details at
>         https://sourceforge.net/p/x3d/code/27706
>         https://sourceforge.net/p/x3d/code/27707
> 
>         please advise if you want arc.3d corrected, or left erroneous as a test case.  if you want it as a test case, then we should add a meta warning to the model so that it is documented & expected.
> 
>         having fun with X3D unit testing!  sometimes it takes a long time to drain the swamp after some major refactoring, but "keeping the build green" is definitely worth it.
> 
>         all the best, Don
>         -- 
>         Don Brutzman  Naval Postgraduate School, Code USW/Br brutzman at nps.edu <mailto:brutzman at nps.edu>
>         Watkins 270,  MOVES Institute, Monterey CA 93943-5000 USA   +1.831.656.2149
>         X3D graphics, virtual worlds, navy robotics http://faculty.nps.edu/brutzman
> 


all the best, Don
-- 
Don Brutzman  Naval Postgraduate School, Code USW/Br       brutzman at nps.edu
Watkins 270,  MOVES Institute, Monterey CA 93943-5000 USA   +1.831.656.2149
X3D graphics, virtual worlds, navy robotics http://faculty.nps.edu/brutzman