[x3d-public] X3DJSAIL updated support for setting with doubles; pythonpyjniusmapping

[John Carlson]

Fixed, checked in.

Do you have an example we can test with?

Thanks,

John

Index: PythonPipeliningSerializer.js
===================================================================
--- PythonPipeliningSerializer.js       (revision 28463)
+++ PythonPipeliningSerializer.js       (working copy)
@@ -82,7 +82,7 @@
                        values.pop();
                }

-               if (type.startsWith("SF")) // TODO fix this javascript, test is not working
+               if (attrType.startsWith("SF"))
             return     lead+values.join(j)+trail; // avoid array brackets on SF types
         else
             return '['+lead+values.join(j)+trail+']';


Sent from Mail for Windows 10

From: John Carlson
Sent: Saturday, May 11, 2019 8:39 PM
To: Brutzman, Donald (Don) (CIV)
Cc: X3D Graphics public mailing list
Subject: RE: X3DJSAIL updated support for setting with doubles; pythonpyjniusmapping


==========================================

>2. Also tried to get PythonPipeliningSerializer.js to avoid brackets on simple and numeric types.

>Checked in block that didn't work, please fix and check back in:

                                if (type.startsWith("SF")) // TODO fix this javascript, test is not working
             return     lead+values.join(j)+trail; // avoid array brackets on SF types
         else
             return '['+lead+values.join(j)+trail+']';

==========================================


I logged type, and these appear to be Java types.  So we’ll have to change type to attrType or something. Will do.

John

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://web3d.org/pipermail/x3d-public_web3d.org/attachments/20190511/41463496/attachment-0001.html>