[x3d-public] patch to JSON schemas
Brutzman, Donald (Don) (CIV)
brutzman at nps.edu
Mon May 27 08:15:46 PDT 2019
Thanks for reference. RFC 1738 defines rules for
Uniform Resource Locators (URL)
which is not the appropriate data structure in this case.
Incidentally it is a good idea to look for latest version, since IETF often publishes errata and updates. In this case
https://tools.ietf.org/html/rfc1738
shows
Obsoleted by: 4248, 4266 PROPOSED STANDARD
Updated by: 1808, 2368, 2396, 3986, 6196, 6270,
8089
and errata at
https://www.rfc-editor.org/errata_search.php?rfc=1738
On 5/26/2019 9:14 PM, Leonard Daly wrote:
> RFC 1738 (https://www.ietf.org/rfc/rfc1738.txt) defines safe and unsafe characters. | is unsafe (pg 2, "Unsafe").
>
> Leonard Daly
>>
>> See link for discussion and link to URI RFC. I’m fairly sure | is not a valid URI character. That is, you can’t issue a POSIX command with pipes in a URI, even though some people would like to. I am pretty sure I’ve tried that and failed 😊
>>
>> https://github.com/everit-org/json-schema/issues/258
>>
>> I hope this satisfies you that I’ve done the right thing. Obviously, we will have to verify through the whole system.
>>
>> In other words, JSON schema says uri or uri-reference, I think. You can check the hyper or meta schema. Good luck!
>>
>> What would you like to use instead that’s a valid URI character?
>>
>> I have generated JSON from fuzz.js and pass the result of fuzz.js through jsonlint. That’s the only testing I’ve done.
>>
>> Wow, I actually sorted this in advance, just had to find the GitHub issue 😊
>>
>> Now I need to tell Ajv that | is not acceptable in a URL.
>>
>> Thanks,
>>
>> John
>>
>> Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
>>
>> *From: *Brutzman, Donald (Don) (CIV) <mailto:brutzman at nps.edu>
>> *Sent: *Sunday, May 26, 2019 2:23 AM
>> *To: *John Carlson <mailto:yottzumm at gmail.com>
>> *Cc: *X3D Graphics public mailing list <mailto:x3d-public at web3d.org>
>> *Subject: *Re: [x3d-public] patch to JSON schemas
>>
>> understood but the right question is what does JSON schema say (if anything).
>>
>> On 5/24/2019 8:00 AM, John Carlson wrote:
>>
>> > Everit would not accept |, so I converted it. I suggest + if that’s acceptable to the validators/schema. Also – would be acceptable to me
>>
>> >
>>
>> > John
>>
>> >
>>
>> > Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
>>
>> >
>>
>> > *From: *Brutzman, Donald (Don) (CIV) <mailto:brutzman at nps.edu>
>>
>> > *Sent: *Friday, May 24, 2019 9:03 AM
>>
>> > *To: *John Carlson <mailto:yottzumm at gmail.com>
>>
>> > *Cc: *X3D Graphics public mailing list <mailto:x3d-public at web3d.org>
>>
>> > *Subject: *Re: [x3d-public] patch to JSON schemas
>>
>> >
>>
>> > Hi John. Thanks for keeping things tuned up as best we can while we await JSON Schema finalization.
>>
>> >
>>
>> > ===================================
>>
>> >
>>
>> > http://json-schema.org
>>
>> >
>>
>> > "The current version is draft-07!"
>>
>> >
>>
>> > "Update as of 31 March 2019. You may be wondering what in the world is going on with this draft? The short version is: we are entering the home stretch. There are some ideas for simplifying $id that we are considering, and then there will be a final review period for feedback on overall flow and clarity."
>>
>> >
>>
>> > ===================================
>>
>> >
>>
>> > and
>>
>> >
>>
>> > https://github.com/json-schema-org/json-schema-spec/milestone/6
>>
>> >
>>
>> > "draft-08, Past due by 4 months, 93% complete. This theme of draft-08 is re-use and modularity."
>>
>> >
>>
>> > ===================================
>>
>> >
>>
>> > The patch you applied using %7C seems less readable and harder to maintain than the existing entries. As an example, I assume that you are modifying constructs such as
>>
>> >
>>
>> > XML Schema
>>
>> >
>>
>> > <xs:element name="skin" type="MFNode" fixed="inputOutputField" default="Group|Transform|Shape|IndexedFaceSet"/>
>>
>> >
>>
>> > X3DUOM
>>
>> >
>>
>> > <field type="MFNode"
>>
>> >
>>
>> > accessType="inputOutput"
>>
>> >
>>
>> > name="skin"
>>
>> >
>>
>> > acceptableNodeTypes="Group|Transform|Shape|IndexedFaceSet"/>
>>
>> >
>>
>> > to produce an excerpt like
>>
>> >
>>
>> > [line 27420]
>>
>> >
>>
>> > "-Group%7CTransform%7CShape%7CIndexedFaceSetMFNode": {
>>
>> >
>>
>> > [lines 9130-9132]
>>
>> >
>>
>> > "-skin": {
>>
>> >
>>
>> > "$ref": "#/definitions/-Group%7CTransform%7CShape%7CIndexedFaceSetMFNode"
>>
>> >
>>
>> > },
>>
>> >
>>
>> > Issues:
>>
>> >
>>
>> > a. what does JSON Schema currently suggest for such constructs?
>>
>> >
>>
>> > b. is the original | character triggering a problem or unacceptable for some reason?
>>
>> >
>>
>> > c. is there any way to validate these schemas yet?
>>
>> >
>>
>> > d. Why is MFNode tacked on the end?
>>
>> >
>>
>> > e. Are you turning acceptableNodeTypes value into a JSON label? If so, perhaps a hyphen is better.
>>
>> >
>>
>> > f. what does fuzz.js do?
>>
>> >
>>
>> > Suggest we plan to give a full scrub when json-schema draft-08 is released, that will also let us provide feedback to them.
>>
>> >
>>
>> > On 5/23/2019 4:51 AM, John Carlson wrote:
>>
>> >
>>
>> > > A patch was made to JSON schema generation to replace | with %7C in more places.
>>
>> >
>>
>> > >
>>
>> >
>>
>> > > All generated JSON schemas were affected
>>
>> >
>>
>> > >
>>
>> >
>>
>> > > This fixed was verified with the fuzz.js JSON schema driven examples.
>>
>> >
>>
>> > >
>>
>> >
>>
>> > > The whole scenario means we need a test plan.
>>
>> >
>>
>> > >
>>
>> >
>>
>> > > New schemas are here:
>>
>> >
>>
>> > >
>>
>> >
>>
>> > > https://github.com/coderextreme/X3DJSONLD/tree/master/src/main/schema
>>
>> >
>>
>> > >
>>
>> >
>>
>> > > John
>>
>> >
>>
>> > all the best, Don
>>
>> >
>>
>> > --
>>
>> >
>>
>> > Don Brutzman Naval Postgraduate School, Code USW/Br brutzman at nps.edu
>>
>> >
>>
>> > Watkins 270, MOVES Institute, Monterey CA 93943-5000 USA +1.831.656.2149
>>
>> >
>>
>> > X3D graphics, virtual worlds, navy robotics http://faculty.nps.edu/brutzman
>>
>> >
>>
>> all the best, Don
>>
>> --
>>
>> Don Brutzman Naval Postgraduate School, Code USW/Br brutzman at nps.edu
>>
>> Watkins 270, MOVES Institute, Monterey CA 93943-5000 USA +1.831.656.2149
>>
>> X3D graphics, virtual worlds, navy robotics http://faculty.nps.edu/brutzman
>>
>>
>> _______________________________________________
>> x3d-public mailing list
>> x3d-public at web3d.org
>> http://web3d.org/mailman/listinfo/x3d-public_web3d.org
>
>
> --
> *Leonard Daly*
> 3D Systems & Cloud Consultant
> LA ACM SIGGRAPH Past Chair
> President, Daly Realism - /Creating the Future/
>
> _______________________________________________
> x3d-public mailing list
> x3d-public at web3d.org
> http://web3d.org/mailman/listinfo/x3d-public_web3d.org
>
all the best, Don
--
Don Brutzman Naval Postgraduate School, Code USW/Br brutzman at nps.edu
Watkins 270, MOVES Institute, Monterey CA 93943-5000 USA +1.831.656.2149
X3D graphics, virtual worlds, navy robotics http://faculty.nps.edu/brutzman
More information about the x3d-public
mailing list