[x3d-public] Already submitted and rejected change to x3d/stylesheets/build.xml

[Michalis Kamburelis]

At least in case of this line:

  <property name=   "node" value="node.exe"/>

you do not need to do anything elaborate (like a switch based on OS).
Just replace it with cross-platform

  <property name=   "node" value="node"/>

As far as I see, you only use this on
https://sourceforge.net/p/x3d/code/HEAD/tree/www.web3d.org/x3d/stylesheets/build.xml#l163
with Ant "exec" task, and there's no need to specify ".exe" extension
on Windows there (see https://ant.apache.org/manual/Tasks/exec.html --
""" In particular, if you do not put a file extension on the
executable, only .EXE files are looked for....""" ).

The current version with .exe extension will fail on any non-Windows
system, including Linux and Mac.

Regards,
Michalis

pon., 7 cze 2021 o 19:57 Don Brutzman <brutzman at nps.edu> napisał(a):
>
> Hi John, as ever thanks for looking at these many capabilities.
>
> We strive for platform neutral.  That looks like a good candidate for using a switch based on OS to create the right property which names the executable.
>
> Here at NPS we are primarily developing on Windows and Mac.
>
> On 6/7/2021 7:10 AM, John Carlson wrote:
> >
> > Please provide a Linux version of build.xml, if possible, or tell me to
> > roll my own.
> >
> > Rolling my own right now.
> >
> > John
> >
> > /c/x3d-code/www.web3d.org$ svn diff
> > Index: x3d/stylesheets/build.xml
> > ===================================================================
> > --- x3d/stylesheets/build.xml   (revision 32158)
> > +++ x3d/stylesheets/build.xml   (working copy)
> > @@ -109,7 +109,7 @@
> >
> >       <property name="stylesheets.dir" location="."/>
> >
> > -    <property name=   "node" value="node.exe"/>
> > +    <property name=   "node" value="node"/>
> >
> >       <!-- ant jar manifest properties -->
> >       <property name="user.name.build" value="Don Brutzman,
> > brutzman at nps.edu"/>
> > @@ -142,9 +142,11 @@
> >           </exec>
> >           <!--
> > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.saxonica.com%2Fdocumentation9.5%2Fusing-xsl%2Fcommandline.html&data=04%7C01%7Cbrutzman%40nps.edu%7C6d08cf30a5b64aaba03908d929be064a%7C6d936231a51740ea9199f7578963378e%7C0%7C0%7C637586718971829132%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0&sdata=voUOUWmkq4LFYfF7J%2FuynlCw4eOgWOPWGWCMUg7XTFc%3D&reserved=0 -->
> >           <echo>saxon -? help</echo>
> > +<!--
> >           <java classname="net.sf.saxon.Transform"
> > classpath="${saxon.dir}/${saxon.jar};." failonerror="true">
> >           <arg value="-?" description="help information"/>
> >           </java>
> > +-->
> >           <echo></echo>
> >           <!-- Ant environment variables
> > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fant.apache.org%2Fmanual%2FTasks%2Fproperty.html&data=04%7C01%7Cbrutzman%40nps.edu%7C6d08cf30a5b64aaba03908d929be064a%7C6d936231a51740ea9199f7578963378e%7C0%7C0%7C637586718971834113%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0&sdata=PiK56hpeJK3rBzLkLBfNW3Re5GnzpkNTNKNpJKF%2B%2F70%3D&reserved=0 -->
> >           <echo>  ANT_HOME=${env.ANT_HOME}</echo>
> >
>
> all the best, Don
> --
> Don Brutzman  Naval Postgraduate School, Code USW/Br       brutzman at nps.edu
> Watkins 270,  MOVES Institute, Monterey CA 93943-5000 USA   +1.831.656.2149
> X3D graphics, virtual worlds, navy robotics http://faculty.nps.edu/brutzman
>
> _______________________________________________
> x3d-public mailing list
> x3d-public at web3d.org
> http://web3d.org/mailman/listinfo/x3d-public_web3d.org