<div dir="ltr">Hi Don,<br><br><div><div class="gmail_extra"><div class="gmail_quote">On Sun, Sep 3, 2017 at 4:44 PM, Don Brutzman <span dir="ltr"><<a href="mailto:brutzman@nps.edu" target="_blank">brutzman@nps.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">copy: Johannes, Max, Timo<br>
<br>
Andreas, the example result for CoordinateDouble looks excellent. Screen snapshot attached. Thanks!<br>
<br></blockquote><div><br></div><div>You are welcome.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
In addition to your important questions, am also wondering: is there any kind of test suite or acceptance tests that get run before accepting a pull request on the main branch of x3dom on github? Once again, documentation regarding node-addition procedures would be helpful for everyone.<br>
<br></blockquote><div><br></div><div>Automated testing and building using CI tools (such github integrated travis) would be great and actually necessary for continued maintenance. It requires a dedicated effort by some but should be doable, at least the building.<br></div><div>I think for now it is necessary for somebody to spend time on reviewing, testing, and merging. Some of that will be always necessary.<br></div><div><br></div><div>I submitted the CoordinateDouble node implementation as a PR:</div><div><a href="https://github.com/x3dom/x3dom/pull/767">https://github.com/x3dom/x3dom/pull/767</a><br></div><div><br></div><div>I also submitted a first (and perhaps pretty final) Integer/BooleanSequencer implementations as a PR:</div><div><a href="https://github.com/x3dom/x3dom/pull/768">https://github.com/x3dom/x3dom/pull/768</a></div><div><br></div><div>The PR has linked example use of these new implementations.<br></div><div><br></div><div>It is somewhat insightful to look at the commit histories to see what I did during the implementation which turned out to be fun due to rapid progress.<br></div><div><br></div><div>I am afraid that studying the code and existing node implementations will remain the main path to learn node-addition procedures. I sort of planned to roughly lay out the key ingredients in the sequencer js code. Perhaps I can add more extensive commenting. I remember I asked questions about fieldChanged and nodeChanged methods on the developer list.<br></div><div><br></div><div>Generally it works best to start with a similar node and modify it a bit.</div><div><br></div><div>Leonard and me had some limited exchanges which may be helpful as well.</div><div><br></div><div>-Andreas<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
On 9/2/2017 1:00 PM, Andreas Plesch wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<a href="https://jsfiddle.net/fzzgso28/1/" rel="noreferrer" target="_blank">https://jsfiddle.net/fzzgso28/<wbr>1/</a><br>
<br>
has only the scene with CoordinateDouble. The CoordinateDouble.js (<a href="https://github.com/andreasplesch/x3dom/blob/CoordinateDouble/src/nodes/Rendering/CoordinateDouble.js" rel="noreferrer" target="_blank">https://github.com/andreasple<wbr>sch/x3dom/blob/CoordinateDoubl<wbr>e/src/nodes/Rendering/<wbr>CoordinateDouble.js</a>) implementation is linked under external resources.<br>
<br>
-Andreas<br>
<br>
<br>
On Sat, Sep 2, 2017 at 12:21 PM, Andreas Plesch <<a href="mailto:andreasplesch@gmail.com" target="_blank">andreasplesch@gmail.com</a> <mailto:<a href="mailto:andreasplesch@gmail.com" target="_blank">andreasplesch@gmail.co<wbr>m</a>>> wrote:<br>
<br>
It looks like my response did not make it the x3d-public list Don's response to it then did.<br>
<br>
These days there does not seem to be much of a x3dom developer community although I believe there is still an important x3dom user community.<br>
<br>
Fraunhofer is silent on the lists and on github. Patches via PRs go stale.<br>
<br>
So it comes down to very specific needs on a per project basis to what gets looked at and is deemed critical. Some users just modify x3dom itself to fit their needs.<br>
<br>
The x3dom profile discussion happened a long time ago:<br>
<br>
<a href="https://www.x3dom.org/nodes-2/" rel="noreferrer" target="_blank">https://www.x3dom.org/nodes-2/</a><br>
<br>
Nevertheless, I bit and implemented CoordinateDouble as a node identical to Coordinate except for naming. x3dom cannot distinguish between MFVec3f and MFVec3d.<br>
<br>
<a href="https://github.com/andreasplesch/x3dom/blob/CoordinateDouble/src/nodes/Rendering/CoordinateDouble.js" rel="noreferrer" target="_blank">https://github.com/andreasples<wbr>ch/x3dom/blob/CoordinateDouble<wbr>/src/nodes/Rendering/<wbr>CoordinateDouble.js</a> <<a href="https://github.com/andreasplesch/x3dom/blob/CoordinateDouble/src/nodes/Rendering/CoordinateDouble.js" rel="noreferrer" target="_blank">https://github.com/andreasple<wbr>sch/x3dom/blob/CoordinateDoubl<wbr>e/src/nodes/Rendering/<wbr>CoordinateDouble.js</a>><br>
<br>
It can be used by simply loading the script after x3dom.js:<br>
<br>
<a href="https://jsfiddle.net/fzzgso28/" rel="noreferrer" target="_blank">https://jsfiddle.net/fzzgso28/</a><br>
<br>
I do not think there are other files which need to be touched.<br>
<br>
Perhaps that provides some insight,<br>
<br>
Andreas<br>
<br>
-- Andreas Plesch<br>
39 Barbara Rd.<br>
Waltham, MA 02453<br>
</blockquote>
<br>
all the best, Don<span class="gmail-HOEnZb"><font color="#888888"><br>
-- <br>
Don Brutzman Naval Postgraduate School, Code USW/Br <a href="mailto:brutzman@nps.edu" target="_blank">brutzman@nps.edu</a><br>
Watkins 270, MOVES Institute, Monterey CA 93943-5000 USA <a href="tel:%2B1.831.656.2149" value="+18316562149" target="_blank">+1.831.656.2149</a><br>
X3D graphics, virtual worlds, navy robotics <a href="http://faculty.nps.edu/brutzman" rel="noreferrer" target="_blank">http://faculty.nps.edu/brutzma<wbr>n</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature">Andreas Plesch<br>39 Barbara Rd.<br>Waltham, MA 02453</div>
</div></div></div>