<div dir="ltr"><div>Michalis,</div><a href="https://github.com/michaliskambi/x3d-tests/wiki/Make-RGB-and-grayscale-textures-treatment-consistent">https://github.com/michaliskambi/x3d-tests/wiki/Make-RGB-and-grayscale-textures-treatment-consistent</a><br><div><a href="https://github.com/michaliskambi/x3d-tests/wiki/Make-RGB-and-grayscale-textures-treatment-consistent#exact-equations-change">https://github.com/michaliskambi/x3d-tests/wiki/Make-RGB-and-grayscale-textures-treatment-consistent#exact-equations-change</a><br></div><div>OK, looks good to me - I approve for v4 on behalf of freewrl project.</div><div>Mar 7, 2018, 1:47pm GMT.<br></div><div>I wonder what other browser developers think.</div><div>-Doug</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 7, 2018 at 4:04 AM, Michalis Kamburelis <span dir="ltr"><<a href="mailto:michalis.kambi@gmail.com" target="_blank">michalis.kambi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">2018-03-07 2:59 GMT+01:00 GPU Group <<a href="mailto:gpugroup@gmail.com">gpugroup@gmail.com</a>>:<br>
> Michalis,<br>
> <a href="http://dug9.users.sourceforge.net/web3d/temp/lighting_4_draft0.html" rel="noreferrer" target="_blank">http://dug9.users.sourceforge.<wbr>net/web3d/temp/lighting_4_<wbr>draft0.html</a><br>
> - is this what you mean for blending - changes to the lighting tables, do I<br>
> have it right?<br>
<br>
</span>Your table changes on<br>
<a href="http://dug9.users.sourceforge.net/web3d/temp/lighting_4_draft0.html" rel="noreferrer" target="_blank">http://dug9.users.sourceforge.<wbr>net/web3d/temp/lighting_4_<wbr>draft0.html</a><br>
are not *exactly* what I propose.<br>
<br>
I have updated my page<br>
<a href="https://github.com/michaliskambi/x3d-tests/wiki/Make-RGB-and-grayscale-textures-treatment-consistent" rel="noreferrer" target="_blank">https://github.com/<wbr>michaliskambi/x3d-tests/wiki/<wbr>Make-RGB-and-grayscale-<wbr>textures-treatment-consistent</a><br>
, and included a new proposed versions of these tables, with changes<br>
marked in bold. See the section "Exact equations change", direct link:<br>
<a href="https://github.com/michaliskambi/x3d-tests/wiki/Make-RGB-and-grayscale-textures-treatment-consistent#exact-equations-change" rel="noreferrer" target="_blank">https://github.com/<wbr>michaliskambi/x3d-tests/wiki/<wbr>Make-RGB-and-grayscale-<wbr>textures-treatment-consistent#<wbr>exact-equations-change</a><br>
<br>
Many thanks for encouraging me to do this, I think that the point is<br>
clearer (and more precise) now.<br>
<br>
As for why your changes on<br>
<a href="http://dug9.users.sourceforge.net/web3d/temp/lighting_4_draft0.html" rel="noreferrer" target="_blank">http://dug9.users.sourceforge.<wbr>net/web3d/temp/lighting_4_<wbr>draft0.html</a><br>
are not *exactly* what I had in mind:<br>
<br>
1. In your table, if we have a Color node <> NULL, then you multiply<br>
Color node (I_Crgb) with Material.diffuseColor (I_Drgb). Thus you<br>
would change more than I propose. Right now, the X3D specification<br>
says that the Color node (if present) effectively replaces<br>
Material.diffuseColor, i.e. Material.diffuseColor is ignored when<br>
Color node is present. And I do not propose to change it, as I think<br>
it's acceptable.<br>
<br>
    (To be clear: I would *also* be OK with multiplying<br>
"Material.diffuseColor * Color node". But the behavior when Color node<br>
replaces Material.diffuseColor is also OK, and this is consistently<br>
implemented as far as I tested. So I do *not* want to break<br>
compatibility here.)<br>
<br>
2. You do not show that Material alpha (1-transparency) is multiplied<br>
by texture alpha.<br>
<br>
    (In my initial proposal version, I indeed wanted to avoid talking<br>
about alpha. But our conversation in this thread shown me that it<br>
should be discussed (and changed) along with RGB.)<br>
<br>
Thank you.<br>
<br>
Best regards,<br>
Michalis<br>
</blockquote></div><br></div>