<div><div dir="auto">I believe that there’s a similar issue with joints? I’m on my back so it’s it hard to check.</div><div dir="auto"><br></div><div dir="auto">We’ve been through this before. </div><div dir="auto"><br></div><div dir="auto">joints should be sequence<string> or just string?</div><div dir="auto"><br></div><div dir="auto">John</div></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Jun 20, 2020 at 3:29 PM John Carlson <<a href="mailto:yottzumm@gmail.com">yottzumm@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div dir="ltr">Don, also change examples in HAnim 2 standard, if there are any.<div><br></div><div>Thanks,</div><div><br></div><div>John</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Jun 20, 2020 at 12:47 PM Don Brutzman <<a href="mailto:brutzman@nps.edu" target="_blank">brutzman@nps.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">[added: HAnim working group]<br>
<br>
Hmmm, I think the comparison reveals a potential flaw in the specifications.<br>
<br>
On 6/18/2020 11:19 PM, J. Scheurich wrote:> HAnimMotion : X3DChildNode<br>
SFString [in,out] channels []<br>
> <br>
> Shouldnt it be<br>
> HAnimMotion : X3DChildNode<br>
> SFString [in,out] channels ""<br>
<br>
Default value [] corresponds to MFString, default value "" corresponds to SFString. You've found a mismatch.<br>
<br>
Investigating further:<br>
===================================================================<br>
<br>
[1] HAnim Part 2: Humanoid animation (HAnim) motion data animation<br>
6 HAnim motion data animation using Motion objects<br>
6.3 Data structure of Motion object<br>
<a href="https://www.web3d.org/documents/specifications/19774/V2.0/MotionDataAnimation/MotionNodes.html#MotionObject" rel="noreferrer" target="_blank">https://www.web3d.org/documents/specifications/19774/V2.0/MotionDataAnimation/MotionNodes.html#MotionObject</a><br>
<br>
interface Motion {<br>
string description ""<br>
string channels ""<br>
sequence<Boolean> channelsEnabled []<br>
double cycleTime<br>
double elapsedTime<br>
Boolean enabled false<br>
int frameCount 0 [0, ∞)<br>
float frameDuration 0.1 (0, ∞)<br>
int frameIncrement 1 (-∞, ∞)<br>
int frameIndex 0 [0, ∞)<br>
string joints ""<br>
integer loa -1 [-1,4]<br>
Boolean loop false<br>
Boolean next<br>
Boolean previous<br>
sequence<float> values [] (-∞,∞)<br>
}<br>
<br>
"The channels field consists of a list, for each joint, of the number of channels for transformation, followed by the transformation type of each channel of data for that joint. Each value shall be separated by a comma and/or one or more spaces. Channels within a given Motion object are enabled by default, unless otherwise indicated by the corresponding Boolean entry in the channelsEnabled field."<br>
===================================================================<br>
<br>
[2] X3D4 Part 1: Architecture and base components<br>
26 Humanoid Animation (HAnimH-Anim) component<br>
26.3.4 HAnimMotion<br>
<br>
HAnimMotion : X3DChildNode {<br>
SFString [in,out] channels []<br>
MFBool [in,out] channelsEnabled []<br>
SFTime [out] cycleTime<br>
SFString [in,out] description ""<br>
SFTime [out] elapsedTime (0,∞)<br>
SFBool [in,out] enabled TRUE<br>
SFInt32 [out] frameCount [0,∞)<br>
SFTime [in,out] frameDuration 0.1 (0,∞)<br>
SFInt32 [in,out] frameIncrement 1 (-∞,∞)<br>
SFInt32 [in,out] frameIndex 0 (0,∞)<br>
MFString [in,out] joints []<br>
SFInt32 [in,out] loa -1 [-1,4]<br>
SFBool [in,out] loop false<br>
SFNode [in,out] metadata NULL [X3DMetadataObject]<br>
SFBool [in] next<br>
SFBool [in] previous<br>
MFFloat [in,out] values [] (-∞,∞)<br>
}<br>
===================================================================<br>
<br>
The HAnim2 specification is the governing reference.<br>
<br>
It appears crystal clear that the channels field is a list.<br>
<br>
Therefore you have found an important error - great work! As remedy, we should have the following interface definitions:<br>
<br>
HAnim2 change:<br>
<br>
string channels ""<br>
to<br>
sequence<string> channels ""<br>
<br>
and corresponding X3D4 change:<br>
<br>
SFString [in,out] channels []<br>
to<br>
MFString [in,out] channels []<br>
<br>
Meanwhile it looks like the corresponding channelsEnabled field is properly defined, and having both fields (channels and channelsEnabled) as matching list/MF array types simplifies implementation considerably.<br>
<br>
Looking forward to review and confirmation, improvement and resolution. Have entered a pair of Mantis issues needed to correct each specification:<br>
<br>
[3] Mantis 1311: Incorrect type defined for HAnimMotion channels field in HAnim2<br>
<a href="https://www.web3d.org/member-only/mantis/view.php?id=1311" rel="noreferrer" target="_blank">https://www.web3d.org/member-only/mantis/view.php?id=1311</a><br>
<br>
[4] Mantis 1312: Mismatched type defined for HAnimMotion channels field in X3D4<br>
<a href="https://www.web3d.org/member-only/mantis/view.php?id=1312" rel="noreferrer" target="_blank">https://www.web3d.org/member-only/mantis/view.php?id=1312</a><br>
<br>
As ever, we continue review discussion of issues on mailing lists, and the specification editors use Mantis issue to track consensus and resolution of changes.<br>
<br>
Thanks for reporting this problem. Good luck with further implementation/evaluation efforts (of cool content!) to confirm/improve the HAnim2 and X3D4 specifications.<br>
<br>
all the best, Don<br>
-- <br>
Don Brutzman Naval Postgraduate School, Code USW/Br <a href="mailto:brutzman@nps.edu" target="_blank">brutzman@nps.edu</a><br>
Watkins 270, MOVES Institute, Monterey CA 93943-5000 USA +1.831.656.2149<br>
X3D graphics, virtual worlds, navy robotics <a href="http://faculty.nps.edu/brutzman" rel="noreferrer" target="_blank">http://faculty.nps.edu/brutzman</a><br>
</blockquote></div>
</blockquote></div></div>