[x3d-public] X3DJSAIL non-critical fix.
yottzumm at gmail.com
yottzumm at gmail.com
Sun Apr 23 19:28:16 PDT 2017
It’s a label followed by a comment. Cute eh?
John
Sent from Mail for Windows 10
From: Don Brutzman
Sent: Sunday, April 23, 2017 4:47 PM
To: yottzumm at gmail.com
Cc: X3D Graphics public mailing list
Subject: Re: X3DJSAIL non-critical fix.
wow, now fixed. how on earth did that stray url pass compilation before?
On 4/20/2017 12:27 AM, yottzumm at gmail.com wrote:
> In X3DConcreteNode.java, I think this URL needs to be commented out (see highlighted red):
>
> protected final void setConcreteUSE(String newValue)
>
> {
>
> if (newValue == null)
>
> newValue = new String(); // Principle of Least Astonishment (POLA)
>
> https://en.wikipedia.org/wiki/Principle_of_least_astonishment
>
> // Check that newValue parameter meets naming requirements before assigning to scene graph
>
> if (!newValue.isEmpty() && !org.web3d.x3d.jsail.fields.SFStringObject.isNMTOKEN(newValue))
>
> {
>
> throw new org.web3d.x3d.sai.InvalidFieldValueException(getElementName() + " USE newValue=\"" + newValue +
>
> "\" has an illegal value, must provide a valid NMTOKEN name string.");
>
> }
>
> USE = newValue;
>
> }
all the best, Don
--
Don Brutzman Naval Postgraduate School, Code USW/Br brutzman at nps.edu
Watkins 270, MOVES Institute, Monterey CA 93943-5000 USA +1.831.656.2149
X3D graphics, virtual worlds, navy robotics http://faculty.nps.edu/brutzman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://web3d.org/pipermail/x3d-public_web3d.org/attachments/20170423/9bc3ec4f/attachment-0001.html>
More information about the x3d-public
mailing list