[x3d-public] Interesting max/round off issue
Vincent Marchetti
vmarchetti at kshell.com
Sun Mar 1 04:45:33 PST 2026
I think this serves as an example of overeager validation, not overeager rounding.
If validation is going to be a useful tool it should serve to warn of practical errors. The issue raised here could happen regardless of any additional rounding applied beyond that due to floating point representation.
I suggest that a practical validation for this case would be to compare the groundAngle to 2.0 This will allow users to achieve the intentian of a groundAngle of pi/2 without giving false validation errors, and it would raise a red flag if the author mistakenly entered 180 for the groundAngle.
It's always the code developer responsibility to catch mathematically invalid input values at run time.
Vince Marchetti
> On Mar 1, 2026, at 3:39 AM, John Carlson via x3d-public <x3d-public at web3d.org> wrote:
>
> Any comments on overeager rounding, which causes validation failures? Maximum angle is 1.5708, which rounds off to 1.571, which is too big. Problem is with Background.groundAngle. An argument for always validating?
>
> I didn’t notice an issue visually until trying to interpret schema validation issues.
>
> Any JavaScript filters for fixing overflows is welcome!
>
> As Joe says, sometimes you just want to go into user code and fix it.
>
> What if this had happened with .glb?
>
> John
>
>
> Error below:
> keyword: maximum
> schema location: $defs > Background > oneOf > 1 > properties > @groundAngle > items > maximum
> schema value: 1.5708
> instance location: X3D > Scene > -children > 0 > Background > @groundAngle > 1
> instance value: 1.571
> instance shorthand value: 1.571
> _______________________________________________
> x3d-public mailing list
> x3d-public at web3d.org
> http://web3d.org/mailman/listinfo/x3d-public_web3d.org
More information about the x3d-public
mailing list