[x3d-public] patch to JSON schemas

John Carlson yottzumm at gmail.com
Fri May 24 08:00:47 PDT 2019


Everit would not accept |, so I converted it.  I suggest + if that’s acceptable to the validators/schema. Also – would be acceptable to me

John

Sent from Mail for Windows 10

From: Brutzman, Donald (Don) (CIV)
Sent: Friday, May 24, 2019 9:03 AM
To: John Carlson
Cc: X3D Graphics public mailing list
Subject: Re: [x3d-public] patch to JSON schemas

Hi John.  Thanks for keeping things tuned up as best we can while we await JSON Schema finalization.

===================================
http://json-schema.org

"The current version is draft-07!"

"Update as of 31 March 2019.  You may be wondering what in the world is going on with this draft? The short version is: we are entering the home stretch. There are some ideas for simplifying $id that we are considering, and then there will be a final review period for feedback on overall flow and clarity."
===================================
and

https://github.com/json-schema-org/json-schema-spec/milestone/6

"draft-08, Past due by 4 months, 93% complete.  This theme of draft-08 is re-use and modularity."
===================================

The patch you applied using %7C seems less readable and harder to maintain than the existing entries.  As an example, I assume that you are modifying constructs such as

XML Schema
	<xs:element name="skin" type="MFNode" fixed="inputOutputField" default="Group|Transform|Shape|IndexedFaceSet"/>

X3DUOM
	<field type="MFNode"
                    accessType="inputOutput"
                    name="skin"
                    acceptableNodeTypes="Group|Transform|Shape|IndexedFaceSet"/>

to produce an excerpt like

[line 27420]
	"-Group%7CTransform%7CShape%7CIndexedFaceSetMFNode": {

[lines 9130-9132]
	"-skin": {

               "$ref": "#/definitions/-Group%7CTransform%7CShape%7CIndexedFaceSetMFNode"

             },

Issues:
a. what does JSON Schema currently suggest for such constructs?
b. is the original | character triggering a problem or unacceptable for some reason?
c. is there any way to validate these schemas yet?
d. Why is MFNode tacked on the end?
e. Are you turning acceptableNodeTypes value into a JSON label?  If so, perhaps a hyphen is better.
f. what does fuzz.js do?

Suggest we plan to give a full scrub when json-schema draft-08 is released, that will also let us provide feedback to them.


On 5/23/2019 4:51 AM, John Carlson wrote:
> A patch was made to JSON schema generation to replace | with %7C in more places.
> 
> All generated JSON schemas were affected
> 
> This fixed was verified with the fuzz.js JSON schema driven examples.
> 
> The whole scenario means we need a test plan.
> 
> New schemas are here:
> 
> https://github.com/coderextreme/X3DJSONLD/tree/master/src/main/schema
> 
> John


all the best, Don
-- 
Don Brutzman  Naval Postgraduate School, Code USW/Br       brutzman at nps.edu
Watkins 270,  MOVES Institute, Monterey CA 93943-5000 USA   +1.831.656.2149
X3D graphics, virtual worlds, navy robotics http://faculty.nps.edu/brutzman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://web3d.org/pipermail/x3d-public_web3d.org/attachments/20190524/c1e3acfc/attachment-0001.html>


More information about the x3d-public mailing list