[x3d-public] X3Dv4 Physically Based Rendering (PBR) review: github pull request instructions

Don Brutzman brutzman at nps.edu
Fri Jan 3 10:31:01 PST 2020

Michalis, Dick and Don reviewed member-only spec changes on Github.  These minutes describe "how to review a draft specification pull request" there.

List of 22 Web3D members with access:


There is a Pull Request that Michalis has produced which collects these changes.
a. https://github.com/Web3DConsortium

b. X3D specifications tree

c. X3D Pull requests

d. [WIP] PBR and other lighting and material upgrades

contains summary and discussion of changes.

e. Files changed

Shows side-by-side diffs of modified specification files.

f. "Changes from all commits" lets you look at the commits as they occurred in this pull request (PR).

g. "Jump to" lets you select file of interest.

h.  Another way to look at the PR is to perform a 'git clone' to your local computer.

Looking at the PR page:

	[WIP] PBR and other lighting and material upgrades #8

	michaliskambi wants to merge 9 commits into Web3DConsortium:master from

which offers, like other github pages, a green [Clone or Download] button, allowing either ssh or https.

https clone for (picking a local-directory name) MichalisPbrPullRequest8:


Any number of tools support github editing - including the web interface itself.  For Netbeans at least, need to perform checkout of both master and the remote branch, ensuring it is completely independent of any other checkout.  Also take care to checkout just the branch on the second window... screenshots attached.

Example page of interest:


The last screenshot #4 shows his styled PR8 pages installed and rendering on my local machine following the clone.  8)

Future work: we will need to come up with better HTML presentation for specification, improving on current CSS to match the permissions which ISO granted (thanks to our prior urging with HAnim) to improve the HTML layout.  It is possible that ISO will only want HTML4 for their document (we'll find out during annual meeting next summer) but Web3D will have the further option to publish using HTML5 should we so choose, as long as document information is the same.

Thanks Michalis for steady efforts.  We meet again weekly Tuesdays at 0900-1000 pacific to continue PBR spec editing.

all the best, Don
Don Brutzman  Naval Postgraduate School, Code USW/Br       brutzman at nps.edu
Watkins 270,  MOVES Institute, Monterey CA 93943-5000 USA   +1.831.656.2149
X3D graphics, virtual worlds, navy robotics http://faculty.nps.edu/brutzman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NetbeansGithubPR8Clone1.png
Type: image/png
Size: 26460 bytes
Desc: not available
URL: <http://web3d.org/pipermail/x3d-public_web3d.org/attachments/20200103/0b82f455/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NetbeansGithubPR8Clone2.png
Type: image/png
Size: 28555 bytes
Desc: not available
URL: <http://web3d.org/pipermail/x3d-public_web3d.org/attachments/20200103/0b82f455/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NetbeansGithubPR8Clone3.png
Type: image/png
Size: 53155 bytes
Desc: not available
URL: <http://web3d.org/pipermail/x3d-public_web3d.org/attachments/20200103/0b82f455/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NetbeansGithubPR8Clone4.png
Type: image/png
Size: 79183 bytes
Desc: not available
URL: <http://web3d.org/pipermail/x3d-public_web3d.org/attachments/20200103/0b82f455/attachment-0007.png>

More information about the x3d-public mailing list